Uploaded image for project: 'SAFe Program'
  1. SAFe Program
  2. SP-1514

Refactoring of CSP.LMC - part 3 - Master/Control Refactoring

    XporterXMLWordPrintable

Details

    • Obs Mgt & Controls
    • Hide

      The CSP.LMC has grown in size and complexity and it needs cleaning. We propose a complete refactoring of CSP.LMC. This is a large but necessary work, but it will be eased by a clean and organic structure: it will give short and long term benefits in both development effort and maintenance costs. This Feature is the third of a series started with the plan developed in SP-1512

      Show
      The CSP.LMC has grown in size and complexity and it needs cleaning. We propose a complete refactoring of CSP.LMC. This is a large but necessary work, but it will be eased by a clean and organic structure: it will give short and long term benefits in both development effort and maintenance costs. This Feature is the third of a series started with the plan developed in  SP-1512
    • Hide

      The code od CSP.LMC Master/Control is refactored according to SP-1512 plan, it implements all the interactions and tests of the pre-refactoring version.

      Show
      The code od CSP.LMC Master/Control is refactored according to SP-1512 plan, it implements all the interactions and tests of the pre-refactoring version.
    • 2
    • 2
    • 13
    • 6.5
    • Team_CREAM
    • Sprint 2
    • Hide

      The code of ska-csp-lmc-common and ska-csp-lmc-mid was refactored according to the plan defined in SP-1512. Furthermore, all the functionalities were implemented using the component manager planned for BC 0.11.

      A C&C view is available on confluence solution intent: https://confluence.skatelescope.org/pages/viewpage.action?pageId=148818174

      Further documentation for CSP.LMC Controller can be found at: https://confluence.skatelescope.org/display/SE/Controller

      The behavior of the Mid.CSP.LMC is described also with BDD tests: https://gitlab.com/ska-telescope/ska-csp-lmc-mid/-/blob/master/tests/integration/features/controller_basic_commands.feature

      Code coverage is 82% for MID and 86% for COMMON.

      Links to code:
      https://gitlab.com/ska-telescope/ska-csp-lmc-common
      https://gitlab.com/ska-telescope/ska-csp-lmc-mid

      Show
      The code of ska-csp-lmc-common and ska-csp-lmc-mid was refactored according to the plan defined in SP-1512 . Furthermore, all the functionalities were implemented using the component manager planned for BC 0.11. A C&C view is available on confluence solution intent: https://confluence.skatelescope.org/pages/viewpage.action?pageId=148818174 Further documentation for CSP.LMC Controller can be found at: https://confluence.skatelescope.org/display/SE/Controller The behavior of the Mid.CSP.LMC is described also with BDD tests: https://gitlab.com/ska-telescope/ska-csp-lmc-mid/-/blob/master/tests/integration/features/controller_basic_commands.feature Code coverage is 82% for MID and 86% for COMMON. Links to code: https://gitlab.com/ska-telescope/ska-csp-lmc-common https://gitlab.com/ska-telescope/ska-csp-lmc-mid
    • 12.4
    • Stories Completed, Integrated, Solution Intent Updated, BDD Testing Passes (no errors), Outcomes Reviewed, Demonstrated, Satisfies Acceptance Criteria, Accepted by FO

    • PI22 - UNCOVERED

    • CSP.LMC Cross_Team_Code_Review Team_CREAM technical_debt

    Description

      The release of the skeleton for sub-element base classes was completed, and, while many functionalities are still lacking,  the CSP.LMC has grown in size and complexity. The update of CSP.LMC Master and Subarray is on the way, while the implementation of the new
      configuration (ADR - 18) and the (very minimal) test of ADR-22 are completed.

      To fully benefits of all above improvement and to proceed in the way of more and more complete implementation of a real word control system the CSP.LMC needs a radical cleaning. 

      A clean and organic structure (developed in SP-1512) will give short and long term benefits in both development effort and maintenance costs. 

      This Feature is the third of a series and will deliver a refactoring of CSP Control device (formerly Master).

      Attachments

        Issue Links

          Child Of

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. SS-8 Technical Debt - Feature Set

          • Could have - Items labelled as "Could have" are desirable but not necessary and could improve the user experience or customer satisfaction for a little development cost. These will typically be included if time and resources permit.
          • Done
          depends on

          Spike - A time limited investigation to get some knowledge SP-1512 Refactoring of CSP.LMC - part 1 - Draft plan

          • Not Assigned - Priority is not assigned yet.
          • Done
          is required by

          Feature - A Feature is a service that fulfills a stakeholder need. Each feature includes a benefit hypothesis and acceptance criteria, and is sized or split as necessary to be delivered by a single Agile Release Train (ART) in a Program Increment (PI). SP-1518 Utilities for the CSP.LMC and CSP Sub element Monitoring and Wrap-up

          • Should have - Items labelled as "Should have" are important but not necessary for delivery in the current delivery timebox. While "Should have" items can be as important as "Must have", they are often not as time-critical or there may be another way to satisfy the requirement so that it can be held back until a future delivery timebox.
          • Analyzing

          Feature - A Feature is a service that fulfills a stakeholder need. Each feature includes a benefit hypothesis and acceptance criteria, and is sized or split as necessary to be delivered by a single Agile Release Train (ART) in a Program Increment (PI). SP-1515 CSP.LMC fault detection and handling

          • Must have - Items labelled as "Must have" are critical to the current delivery timebox in order for it to be a success.
          • Done
          relates to

          Enabler - An Enabler supports the activities needed to extend the Architectural Runway to provide future business functionality. These include exploration, architecture, infrastructure, and compliance. SS-54 Review of Control Systems guidelines and refactoring of implementation

          • Not Assigned - Priority is not assigned yet.
          • Implementing

          Structure

            Activity

              People

                s.vrcic Vrcic, Sonja
                c.baffa Carlo Baffa
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Feature Progress

                  Story Point Burn-up: (100.00%)

                  Feature Estimate: 2.0

                  IssuesStory Points
                  To Do00.0
                  In Progress   00.0
                  Complete1331.0
                  Total1331.0

                  Dates

                    Created:
                    Updated:
                    Resolved:

                    Structure Helper Panel