DISH.LMC implements the correct DISH ID format (ADR-32)

Adopt use of the correct Dish IDs.

Why now:  DISH ID is used in virtually all M&C components in the MID Telescope.  Current implementation uses numerical only DISH IDs which does not align with the actual DISH ID defined  by the SKA documents and used by the Telescope Delivery Teams,  Contractors and Operations. 

All user interfaces, including logs, alarms, and dashboards,  should use the correct DISH ID  to avoid misunderstanding.   A maintenance person in the desert should see the same DISH ID painted on the dish, shown in technical documents and diagrams,  and displayed on the screens.

DISH ID is embedded in the digitized data flowing from the DISH (more specifically SPFRx) to CBF, if we use different IDs internally and externally that will inevitably lead to confusion.

If implemented early, this is a small change that affects many components.

If we continue using numeric-only Dish ID, user interfaces and other interface software will need to be updated later when the Meerkat dishes are integrated, i.e. when  the bulk of M&C software has been developed, integrated and released. By that time we will develop  many more software components and user interfaces and the change will require more resources.

Device names of Dish LMC devices contain the Dish ID as per ADR-32.

A Dish LMC acceptance test in ska-dish-lmc pipeline demonstrates propagation of Dish ID through Dish LMC to SPFRx as per ADR-32.

A Dish LMC acceptance test in ska-dish-lmc pipeline demonstrates propagation of Dish ID through Dish LMC to SPFRx as per ADR-32 to the logs of the TANGO devices of Dish.

Implementation of Dish ID in Dish LMC was discussed and shared with architects and Cipa team - see Dish ID Dish LMC design

Device names of Dish LMC devices contain the Dish ID as per ADR-32.

• Device names of Dish LMC devices are listed in 2023-03-28 Dish LMC Weekly Meeting notes
• demonstrated in https://confluence.skatelescope.org/display/SE/2023-04-20+OMC+ART+System+Demo+18.3

A Dish LMC acceptance test in ska-dish-lmc pipeline demonstrates propagation of Dish ID through Dish LMC to SPFRx as per ADR-32.

• This test is not applicable because the Dish ID is set as a device property of SPFRx Controller TANGO device in the Dish TANGO database - see Dish ID Dish LMC design

A Dish LMC acceptance test in ska-dish-lmc pipeline demonstrates propagation of Dish ID through Dish LMC to SPFRx as per ADR-32 to the logs of the TANGO devices of Dish.

• test_dish_lmc_log_forwarding in ska-dish-lmc pipeline
• demonstrated in 2023-05-11 Dish LMC Weekly Meeting