Uploaded image for project: 'SAFe Program'
  1. SAFe Program
  2. SP-2573

Port Dish LMC's DishMaster device to Python for SPFRx control

Change Owns to Parent OfsSet start and due date...
    XporterXMLWordPrintable

Details

    • Enabler
    • Must have
    • PI15
    • None
    • True
    • Obs Mgt & Controls
    • Hide

      Improved maintainability and quality of Dish LMC.

      Show
      Improved maintainability and quality of Dish LMC.
    • Hide

      DishManager TANGO attributes and commands are described in Developer Portal.

      DishManager conforms to Definition of Done.

      No regression in Dish LMC test results.

      DishManager exhibits its desired behaviour: Dish startup, SetStandbyLPMode, SetStandbyFPMode, SetOperateMode, configure band, Track.

      Order of startup of TANGO devices in ska-dish-lmc should not influence the responsiveness of DishManager.

      Show
      DishManager TANGO attributes and commands are described in Developer Portal. DishManager conforms to Definition of Done . No regression in Dish LMC test results. DishManager exhibits its desired behaviour: Dish startup, SetStandbyLPMode, SetStandbyFPMode, SetOperateMode, configure band, Track. Order of startup of TANGO devices in ska-dish-lmc should not influence the responsiveness of DishManager.
    • 7
    • 7
    • 20
    • 2.857
    • Team_KAROO
    • Sprint 4
    • Hide

      DishManager TANGO attributes and commands are described in Developer Portal.

      DishManager conforms to Definition of Done

      • ska-mid-dish-manager repository,
      • Lint for Python, OCI image & Helm: few warnings,
      • Unit tests: coverage 59% (all above 70% except test devices - see report).

      Some regression in Dish LMC test results - see https://confluence.skatelescope.org/display/SE/Dish+LMC+device+status+-+interface+and+test+results.

      • Summary of k8s test:
        • Before: 5 passed, 16 deselected, 14 xfailed, 10 xpassed
        • After:   12 passed, 18 deselected, 12 xfailed,  5 xpassed
      • XTP-5703 and XTP-5414 used to pass but now fail,
      • XTP-813 now has more tests passing,
      • "Dish LMC Initial Values" and "Dish LMC Reporting Models" tests are now passing and stable.

       DishManager exhibits its desired behaviour: Dish startup, SetStandbyLPMode, SetStandbyFPMode, SetOperateMode, configure band, Track.

      Order of startup of TANGO devices in ska-dish-lmc should not influence the responsiveness of DishManager.

      Dish LMC device status - interface and test results has been updated with results of Dish LMC acceptance tests after integration of the new DishManager.

      Show
      DishManager TANGO attributes and commands are described in Developer Portal. SKA developer portal contains  SKA Mid Dish Manager Documentation  which can be navigated to from  Dish LMC Documentation. DishManager conforms to  Definition of Done ska-mid-dish-manager  repository, Lint for Python, OCI image & Helm: few warnings, Unit tests: coverage 59% (all above 70% except test devices - see  report ). Some regression in Dish LMC test results - see  https://confluence.skatelescope.org/display/SE/Dish+LMC+device+status+-+interface+and+test+results. Summary of k8s test: Before: 5 passed, 16 deselected, 14 xfailed, 10 xpassed After:   12 passed, 18 deselected, 12 xfailed,  5 xpassed XTP-5703 and XTP-5414 used to pass but now fail, XTP-813 now has more tests passing, "Dish LMC Initial Values" and "Dish LMC Reporting Models" tests are now passing and stable.  DishManager exhibits its desired behaviour: Dish startup, SetStandbyLPMode, SetStandbyFPMode, SetOperateMode, configure band, Track. https://confluence.skatelescope.org/display/SE/Dish+LMC+device+status+-+interface+and+test+results. Order of startup of TANGO devices in ska-dish-lmc should not influence the responsiveness of DishManager. test_happy_path:  component manager test ,  result, test_dish_manager_remains_in_startup_on_error:  device test ,[result,|https://gitlab.com/ska-telescope/ska-mid-dish-manager/-/jobs/2922433420] test_unhappy_path:  component manager test ,  result, test_device_goes_away:  component manager test ,  result, test_component_manager_continues_reconnecting_when_device_is_unreachable:  component manager test ,  result. Dish LMC device status - interface and test results  has been updated with results of Dish LMC acceptance tests after integration of the new DishManager.
    • 15.6
    • Stories Completed, Outcomes Reviewed, NFRS met, Demonstrated, Satisfies Acceptance Criteria, Accepted by FO
    • PI24 - UNCOVERED

    • Team_KAROO

    Description

      Where do you observe the technical debt in the development artefacts?

      What remedial work is needed to eliminate the debt? Describe the rework needed.

      • Rename DishMaster to DishManager (as per Dish LMC design),
      • Make changes in order to pass tests that passed before the refactoring,
      • Fix DishMaster (renamed DishManager) errors that show up in logs,
      • Add unit tests for DishManager,
      • Add documentation for the new version as per Definition of Done,
      • This work will be done by replacing the existing C++ DishMaster device with a Python ska-tango-base based device as most economic way of adopting the latest version of SKA base classes, considering Karoo team skill set and business logic isolation in the existing code.
      • DishManager health states reflect the status of subservient devices (e.g. not running).

      Why is it important to address this technical debt item i.e. consequences or costs accrued by this item?
      To improve maintainability, enable adding implementation of long running commands, comply to Dish LMC requirements, increase confidence (unit tests). 

      Attachments

        Issue Links

          Structure

            Activity

              People

                Adam.Avison Avison, Adam
                p.swart Swart, Paul [X] (Inactive)
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Feature Progress

                  Story Point Burn-up: (100.00%)

                  Feature Estimate: 7.0

                  IssuesStory Points
                  To Do00.0
                  In Progress   00.0
                  Complete1627.0
                  Total1627.0

                  Dates

                    Created:
                    Updated:
                    Resolved:

                    Structure Helper Panel