Details
-
Feature
-
Not Assigned
-
None
-
Obs Mgt & Controls
-
-
-
2
-
2
-
6.5
-
Team_CREAM, Team_NCRA
-
Sprint 4
-
-
-
-
9.6
-
Stories Completed, Integrated, Solution Intent Updated, BDD Testing Passes (no errors), Outcomes Reviewed, NFRS met, Demonstrated, Satisfies Acceptance Criteria, Accepted by FO
-
-
Cross_Team_Code_Review
-
SPO-863
Description
ADR-18 decided on a change to the structure of the JSON strings used to configure the CSP. This feature implements ADR-18 change in the current MVPs for Mid and Low. The total work is partially in CSP.LMC (receiver, estimated 1FP) and partially in TM (sender, estimated 1FP).
From the ADR page (adapted):
The new structure of configuration json reflects the real structure of the target [sub]element.The CSP configure would have a structure as:
The configure json structure has three main portions:
- the subarray portion. This section contains only the parameters specific to the configuration receiving entity (in current design the subarray device). It is not forwarded.
- the common portion. This section contains only the parameters common to all sub-elements and then it is forwarded to all of them
- the sub-element specific portion.
The new structure, while a little more complex than the previous one has the following advantages:
- For the producing entity it is simpler to organize and maintain the code which configure a specific part.
- For the target entity the gain is analogous, as the sub-elements decode portion does need to know only a specific (‘local’) portion of the possible commands
- For testing and human inspection it is much simpler to collect all related item in a single branch of the complete json.
The current version does not includes all due variables. The lists relative to each sub-elements will be variable with time and will belong more properly to the ICD documentation.
We note that the old and the new format can coexist without harming each other. It is so possible to foresee a transition phase in which both forms are present.
There should be collaboration with the work on SP-1345 to ensure alignment, and also with the NCRA team to cover any impact on the TMC. The work required on this feature and on SP-1345 could be re-arranged if it makes sense to.
In due time the new structure will incorporate json versioning as per ADR-22
Attachments
Issue Links
- relates to
-
SP-1345 Update the CDM to take account of its use in Low and Mid, and incorporate JSON change as a result of ADR-18, also updating the telescope model.
- Done
-
ADR-18 Change in CSP configuration
- decided
- mentioned in
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
- mentioned on