Uploaded image for project: 'SAFe Program'
  1. SAFe Program
  2. SP-2936

Refine and test the PST interface to CSP.LMC

Change Owns to Parent OfsSet start and due date...
    XporterXMLWordPrintable

Details

    • Data Processing
    • Hide

      Enables monitor & control of PST from TMC

      Show
      Enables monitor & control of PST from TMC
    • Hide
      • Comprehensive documentation that describes how to deploy and use PST.LMC
      • Integration tests (written using Gherkin/Cucumber) that verify:
        • successful completion of multiple scans, and changing scan configurations
        • correct error reporting and fault state handling
        • correct handling of the abort and obsReset commands
        • correct reporting of device health state
      Show
      Comprehensive documentation that describes how to deploy and use PST.LMC Integration tests (written using Gherkin/Cucumber) that verify: successful completion of multiple scans, and changing scan configurations correct error reporting and fault state handling correct handling of the abort and obsReset commands correct reporting of device health state
    • 3
    • 3
    • 0
    • Team_PST
    • Sprint 5
    • Hide

      Substantial work on Technical Debt was undertaken in the PST with the majority of the effort involved in refactoring the State Model that is used throughout the signal processing chain (PST CORE). This now allows for a common state model to be used consistently throughout the CORE applications. Other technical debt addressed also included:

      • Ensuring all C++ log messages conform to the SKAO logging standards.
      • Resolving Tango Health state reporting.
      • Refactor the random and sinusoidal data generators to support integration tests.
      • First X-RAY test that make use of the existing gherkin BDD feature files that were developed in earlier PIs.
      • Developed substantial testing of induced errors in the CBF to PST data interface to support many possible failure modes.

      We have ensured that PST-LMC Tango devices are capable of being integrated into a CSP-LMC deployment using kubernetes. This effort required the following key outcomes which have been achieved:

      • The PST-LMC documentation that describes how to deploy and use PST Tango devices was updated and reviewed to ensure it was suitable for use by external stakeholders.
      • Support was provided to the Cream Team to enable the first integration tests when deploying PST-LMC in CSP-LMC's environment.
      • In person meetings were held to review the interface, make finer improvements and adjustments to JSON schema and discuss the extension of the interface beyond AA0.5. 

      The PST "end-to-end" tests that reside in the ska-pst-integration repository have been extended from a single happy-path test to Integration Tests that cover:

      • a single simple scan.
      • multiple scans with identical configuration.
      • multiple scans with differing configuration, this uncovered many poor assumptions in the Tango and PST CORE applications, which have been fixed.
      • aborting during a scan.
      Show
      Substantial work on Technical Debt was undertaken in the PST with the majority of the effort involved in refactoring the State Model that is used throughout the signal processing chain (PST CORE). This now allows for a common state model to be used consistently throughout the CORE applications. Other technical debt addressed also included: Ensuring all C++ log messages conform to the SKAO logging standards. Resolving Tango Health state reporting. Refactor the random and sinusoidal data generators to support integration tests. First X-RAY test that make use of the existing gherkin BDD feature files that were developed in earlier PIs. Developed substantial testing of induced errors in the CBF to PST data interface to support many possible failure modes. We have ensured that PST-LMC Tango devices are capable of being integrated into a CSP-LMC deployment using kubernetes. This effort required the following key outcomes which have been achieved: The  PST-LMC documentation  that describes how to deploy and use PST Tango devices was updated and reviewed to ensure it was suitable for use by external stakeholders. Support was provided to the Cream Team to enable the first integration tests when deploying PST-LMC in CSP-LMC's environment. In person meetings were held to review the interface, make finer improvements and adjustments to JSON schema and discuss the extension of the interface beyond AA0.5.  The PST "end-to-end" tests that reside in the  ska-pst-integration  repository have been extended from a single happy-path test to Integration Tests that cover: a single simple scan. multiple scans with identical configuration. multiple scans with differing configuration, this uncovered many poor assumptions in the Tango and PST CORE applications, which have been fixed. aborting during a scan.
    • 18.3
    • Stories Completed, Outcomes Reviewed, Satisfies Acceptance Criteria, Accepted by FO
    • PI22 - UNCOVERED

    • LOW_SUT2

    Description

      To support integration and testing with CSP.LMC (which will be led by Cream) the PST team will

      • review and update the ska-pst-lmc documentation;
      • improve the robustness of the PST software and the ability to recover when faults and errors occur;
      • ensure that errors are propagated and fault states are consistent through all levels of control (from CORE software to PST Beam logical TANGO device); and
      • develop integration tests that demonstrate
        • the ability to successfully start and stop several scans with one or more configurations
        • the ability to detect and report errors and faults
        • the ability to abort or reset after fault and return to the idle state

      During testing in PI16, it became clear that the state models implemented by the core components of PST (RECV.CORE, SMRB.RB, and DSP.DISK) are not consistent with each other or the PST Beam logical TANGO device that controls them. To address the problem and resolve this Technical Debt, the PST team will abstract a common State Model and update RECV.CORE, SMRB.RB, and DSP.DISK to specialise the behaviour associated with each state and state transition.

      Attachments

        Issue Links

          Structure

            Activity

              People

                A.Noutsos Noutsos, Aristeidis
                a.jameson Andrew Jameson
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Feature Progress

                  Story Point Burn-up: (100.00%)

                  Feature Estimate: 3.0

                  IssuesStory Points
                  To Do00.0
                  In Progress   00.0
                  Complete2033.0
                  Total2033.0

                  Dates

                    Created:
                    Updated:
                    Resolved:

                    Structure Helper Panel