Uploaded image for project: 'SAFe Program'
  1. SAFe Program
  2. SP-1606

CBF Emulator Integration Cleanup

Details

    • Feature
    • Not Assigned
    • PI10
    • COM SDP SW
    • None
    • Data Processing
    • Hide

      For a PSI release our primary goal at this point should be to provide a mature implementation of the CBF emulator integration into Mid.CBF.

      Show
      For a PSI release our primary goal at this point should be to provide a mature implementation of the CBF emulator integration into Mid.CBF.
    • Hide
      1. Tango device refactored so it does not depend on CBF implementation any more
      2. New cbf-emulator chart created and integrated into SKAMPI
      3. An integration test (e.g., an OET script) for testing passing visibilities from CBF emulator to the receive workflow
      4. Stretch: The same as above, but as a Continuous (automatic) Integration test.
      5. Stretch: Test checks that a measurement set with matching visibilities is produced
      Show
      Tango device refactored so it does not depend on CBF implementation any more New cbf-emulator chart created and integrated into SKAMPI An integration test (e.g., an OET script) for testing passing visibilities from CBF emulator to the receive workflow Stretch : The same as above, but as a Continuous (automatic) Integration test. Stretch : Test checks that a measurement set with matching visibilities is produced
    • 3
    • 3
    • Team_YANDA
    • Sprint 5
    • Hide

      Several code repos were touched/patched, most importantly cbf-sdp-emulator-tango-device and also mid-cbf-mcs. Tests were run on AWS instances and later also on PSI-Low by team Viola (SDR-377).

      Show
      Several code repos were touched/patched, most importantly cbf-sdp-emulator-tango-device and also mid-cbf-mcs. Tests were run on AWS instances and later also on PSI-Low by team Viola (SDR-377).
    • 12.4
    • Stories Completed, Integrated, BDD Testing Passes (no errors), Outcomes Reviewed, NFRS met, Demonstrated, Satisfies Acceptance Criteria, Accepted by FO
    • PI22 - UNCOVERED

    Description

      In SPO-944 we realised an integration of the CBF-SDP emulator sender into Mid.CBF. This work was done as a one-off though, without code being committed to any repository, and instead using a custom-built Docker image (available on Nexus). This created some technical debt, which is what's being addressed here.

      There are two main aspects that need attention:

      • Code: the Tango device wrapping the emulator needs to act like a drop-in replacement of the CbfSubarray. It currently inherits from SKASubarray, which doesn't provide all the commands and attributes required for this drop-in replacement to work. It is believed that by inheriting from a different class (also part of the lmc base classes package) the emulator Tango device should be able to act as a replacement for the CbfSubarray without impacting the rest of the system.
      • Deployment: To deploy the emulator Tango device we need to start a device server that starts this new device instead of the original. Additionally, at some level there must be an option to choose between using the original CbfSubarray or the emulated one. Initial discussions suggested that this should be handled at the highest level possible – i.e., by creating a new umbrella chart in SKAMPI to clearly separate both use cases.

      Assumptions:

      • Inheriting from the new class in lmc-base-classes the emulator Tango device as is, is sufficient to function as a drop-in replacement. The CIPA/CREAM is not available in case the base class needs changing.
      • A persistant volume can be set up that contains a measurement set file for meta data. This relates to the stretch goal of automatic CI testing only.

      Attachments

        Issue Links

          Structure

            Activity

              People

                p.wortmann Wortmann, Peter
                m.dolensky Dolensky, Markus [X] (Inactive)
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Feature Progress

                  Story Point Burn-up: (100.00%)

                  Feature Estimate: 3.0

                  IssuesStory Points
                  To Do00.0
                  In Progress   00.0
                  Complete712.0
                  Total712.0

                  Dates

                    Created:
                    Updated:
                    Resolved:

                    Structure Helper Panel