Uploaded image for project: 'SAFe Program'
  1. SAFe Program
  2. SP-1530

CSP_Mid.CBF MCS infrastructure and software enhancements

Change Owns to Parent OfsSet start and due date...
    XporterXMLWordPrintable

Details

    • Enabler
    • Not Assigned
    • PI10
    • None
    • Obs Mgt & Controls
    • Hide

      Increase SW quality and development process efficiency by infrastructure and software enhancements.

      Show
      Increase SW quality and development process efficiency by infrastructure and software enhancements.
      • code updated as per stories description
      • pipeline tests pass and test outcomes have not changed
    • 3
    • 3
    • 2
    • Team_CIPA
    • Sprint 5
    • Hide

      The outcomes of this feature include the following:

      A) The mid-cbf-mcs VCC, FSP PSS mode and and FSP CORR mode configuration capabilities have been updated to support all observing states, the correct transitions and triggering commands as follows:

      1 - Updated to the VCC Tango device class to inherit from the CspSubElementObsDevice base class (rather than from the SAKCapability class) and using the base classes command definition paradigm, ensuring in this way that the observing state state-machine as well as the commands that trigger them can be inherited; all the ad-hoc obState changes have been removed.

      2 - Updated the subordinated 4 VCC_Band* device classes and the VccSearchWindow class to use the InitCommand() class (instead of init_device()) and removed the local SetState() functions.

      3 - Updated, in a similar way to the Vcc class, the FspCorrSubarray and FspPssSubarray Tango device classes.

      4 - Eliminated one level of the client-server hierarchy of tango classes, namely the CbfSubarrayCorrConfig and CbfSubarrayPssConfig classes and moved their functionality to CbfSubarry. In this way scan configuration for the Correlation and PSS modes will be done in one place (FspCorrSubarray and FspPssSubarry class respectively).

      5 - Updated the CbfSubarray class to support all the obsState Vcc an Fsp related updates and interface changes.

      6- Updated pytest testing classes to support the new implementation.

      Note that given that the FSP configuration for the PST mode has been implemented in the same time (story AT5-611) the observing state updates have not been applied for the FSP PST mode; however, the approach is very similar to the one for the Correlation and PSS modes and will be applied in PI11.
      Updates are currently on the https://gitlab.com/ska-telescope/mid-cbf-mcs/-/tree/at5-594-obsState-commands branch and the CICD pipeline passed.

      B) Support for remote-debugging and various aspects of refactoring have been applied to the code base (stories AT5-668 to AT5-671). For the CbfSubarray refactoring a better approach for restructuring the code has been identified (see details in AT5-671 Outcomes). This approach will be discussed with the team and if confirmed, will be adopted in future PIs.

      C) WebJive/Taranta dashboard was set up to display the commands and attribute values of the Mid-CBF MCS devices as they operate, behaving as a graphical user interface through which the system can be configured for scan operations (AT5-678). Devices displayed on the interface include:

      • CbfMaster x1
      • CbfSubarray x3
      • Fsp x4
      • TmCspLeafNodeTest x1
      • Vcc x4
      Show
      The outcomes of this feature include the following: A) The mid-cbf-mcs VCC, FSP PSS mode and and FSP CORR mode configuration capabilities have been updated to support all observing states, the correct transitions and triggering commands as follows: 1 - Updated to the VCC Tango device class to inherit from the CspSubElementObsDevice base class (rather than from the SAKCapability class) and using the base classes command definition paradigm, ensuring in this way that the observing state state-machine as well as the commands that trigger them can be inherited; all the ad-hoc obState changes have been removed. 2 - Updated the subordinated 4 VCC_Band* device classes and the VccSearchWindow class to use the InitCommand() class (instead of init_device()) and removed the local SetState() functions. 3 - Updated, in a similar way to the Vcc class, the FspCorrSubarray and FspPssSubarray Tango device classes. 4 - Eliminated one level of the client-server hierarchy of tango classes, namely the CbfSubarrayCorrConfig and CbfSubarrayPssConfig classes and moved their functionality to CbfSubarry. In this way scan configuration for the Correlation and PSS modes will be done in one place (FspCorrSubarray and FspPssSubarry class respectively). 5 - Updated the CbfSubarray class to support all the obsState Vcc an Fsp related updates and interface changes. 6- Updated pytest testing classes to support the new implementation. Note that given that the FSP configuration for the PST mode has been implemented in the same time (story AT5-611) the observing state updates have not been applied for the FSP PST mode; however, the approach is very similar to the one for the Correlation and PSS modes and will be applied in PI11. Updates are currently on the https://gitlab.com/ska-telescope/mid-cbf-mcs/-/tree/at5-594-obsState-commands branch and the CICD pipeline passed. B) Support for remote-debugging and various aspects of refactoring have been applied to the code base (stories AT5-668 to AT5-671). For the CbfSubarray refactoring a better approach for restructuring the code has been identified (see details in AT5-671 Outcomes). This approach will be discussed with the team and if confirmed, will be adopted in future PIs. C) WebJive/Taranta dashboard was set up to display the commands and attribute values of the Mid-CBF MCS devices as they operate, behaving as a graphical user interface through which the system can be configured for scan operations (AT5-678). Devices displayed on the interface include: CbfMaster x1 CbfSubarray x3 Fsp x4 TmCspLeafNodeTest x1 Vcc x4
    • 10.6
    • Stories Completed, Integrated, Outcomes Reviewed, NFRS met, Demonstrated, Satisfies Acceptance Criteria, Accepted by FO
    • PI24 - UNCOVERED

    • Mid.CBF Team_CIPA

    Description

      • Modify scripts to increase local and CI testing flexibility
      • Enhance pytest unit test classes to increase throughput
      • Setup VSCode for testing/debugging within the docker/Kubernetes framework

      Attachments

        Structure

          Activity

            People

              v.mohile Mohile, Vivek
              M.Radulescu Radulescu, Michelle
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Feature Progress

                Story Point Burn-up: (100.00%)

                Feature Estimate: 3.0

                IssuesStory Points
                To Do00.0
                In Progress   00.0
                Complete725.0
                Total725.0

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Structure Helper Panel